Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configuration setup so it works in Docker #23

Merged
merged 1 commit into from
Jun 19, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion testrunner/config/default.yaml
Original file line number Diff line number Diff line change
@@ -50,7 +50,8 @@ log:

# The default sitespeed.io configuration file used by the sitespeed.io instance
# It will be merged by the server sitespeed.io config and what you add in the
# cli or gui
# cli or gui. If you use a Docker container, make sure to map a volume and use
# the full path to the configuration file
# sitespeedioConfigFile:

# The working directory for the testrunner, where it temporary will put it files
3 changes: 1 addition & 2 deletions testrunner/src/testrunners/docker-testrunner.js
Original file line number Diff line number Diff line change
@@ -44,8 +44,7 @@ export default async function runJob(job) {

// Modify config for use with default settings
if (nconf.get('sitespeedioConfigFile') !== undefined) {
job.data.config.extends =
'./config/' + nconf.get('sitespeedioConfigFile');
job.data.config.extends = nconf.get('sitespeedioConfigFile');
}

await writeFile(