Add .introspectSearchController
#129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @iansampson, I'm sorry your PR was ignored for such a long time. I'll tidy up the branch with the latest from master and get this merged asap. |
davdroman
changed the title
.introspectSearchController modifier, which finds a UISearchController from a SwiftUI.View with a .searchable modifier.introspectSearchController
|
Awesome, thanks @davdroman! I’d completely forgotten about this PR and happy to see it merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With iOS 15, SwiftUI adds a
.searchablemodifier toView, which configures aUISearchControllerwithin the enclosingUINavigationView. This pull request adds a method for introspecting thatUISearchController. Introspection makes it possible to use search features that are not currently available in SwiftUI, such as scope bar buttons.The pull request supports introspecting
UISearchControllerin iOS, but doesn’t yet cover comparable elements in macOS, tvOS, or watchOS (all of which include thesearchablemodifier, in their newest versions). I’d be happy to work on supporting those platforms in the future, if that’s desirable.This is my first contribution to this repository, so feedback and suggestions are more than welcome. Thanks!