Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI issues #179

Closed
SplittyDev opened this issue Jan 24, 2023 · 5 comments
Closed

CircleCI issues #179

SplittyDev opened this issue Jan 24, 2023 · 5 comments
Assignees

Comments

@SplittyDev
Copy link
Collaborator

Hey @ldiqual, it looks like the CircleCI integration isn't working anymore.
Should we just remove it, or do you want to look into it?

We've been running the GitHub CI workflows alongside CircleCI for quite a while now, and it's been working fine, so theoretically there isn't really a need to keep CircleCI working anyway.

@davdroman
Copy link
Collaborator

@ldiqual this is blocking all PRs right now. From what I can see CircleCI auth may have been revoked for this repo so maybe the intention was to fully convert to GitHub Actions? If that's the case I can open a PR to remove the /.circleci directory altogether. I'd just like to get confirmation from you first.

image

@davdroman
Copy link
Collaborator

@ldiqual we need someone with admin rights to uninstall the CircleCI integration from this repo, otherwise we're completely blocked and can't merge any PRs, even with explicit approval (e.g. #168).

joelpoloney added a commit that referenced this issue Feb 10, 2023
Part of #179. I'll remove the config settings once this is merged.
joelpoloney added a commit that referenced this issue Feb 10, 2023
Part of #179. I'll remove the config settings once this is merged.
@joelpoloney
Copy link
Contributor

Apologies for the delay on this one, everyone. I've removed the CircleCI config from the repo and disabled it in settings. Can you confirm that it's no longer causing issues? If so, just close this issue as resolved. Otherwise, let me know and I'll look into it further (CircleCI tends to stick its fingers in a few places... but I think I got em all).

@davdroman
Copy link
Collaborator

davdroman commented Feb 10, 2023

Thank you @joelpoloney! Though ci/circleci: build seems to still appear as part of the PR checks (example) even after rebasing 🤔

Can you take a look please?

image

@davdroman
Copy link
Collaborator

All sorted. Wohoo! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants