Fix memory leak with SQLite #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#520 introduced a memory leak which is caused by loading an ICU collation into new database connections. Whatever memory is reserved by that is not released when closing the connection, and as each request creates a new connection, memory usage just keeps increasing. As the collation loading is external code I don't see how I could fix that. I also don't want to rollback the fix from #520 as the new sort by title feature relies on that as well. As a workaround, this makes SQLite database connections persistent, so that they are only created once and then reused indefinitely. Hoping that this doesn't cause any other issues.