Add option for showing bookmark favicons #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sissbruecker
force-pushed
the
feat/favicons
branch
from
070f68d to
239982a
Compare
sissbruecker
force-pushed
the
feat/favicons
branch
from
b39b83d to
0c9da99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option that will automatically download and show favicons for bookmarks. The option is disabled by default.
Linkding itself does not contain any logic for detecting favicons, converting them into a consistent image format or providing them in a consistent size. Instead, it uses a favicon provider, which for a given URL returns the favicon for the URL. By default, linkding uses a Google service as favicon provider (example: https://t1.gstatic.com/faviconV2?url=https://github.com&client=SOCIAL&type=FAVICON). Users have the option to configure their own favicon provider.
Favicons are downloaded asynchronously in the background, which means it can take a while for them to show up. They are stored in the application's data folder so that they can be backed up. Icons are hosted as static files by linkding's application server.
Screens: