Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order tags in test_should_create_new_bookmark #310

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

RoGryza
Copy link
Contributor

@RoGryza RoGryza commented Aug 2, 2022

This test seems to rely on the tags being queried in a specific order from the database, which is incidentally the case for SQLite.

This came up when I was merging my postgres fork with the latest release here

@sissbruecker
Copy link
Owner

Thanks, could you please also change the edit view test:

self.assertEqual(bookmark.tags.all()[0].name, 'editedtag1')
self.assertEqual(bookmark.tags.all()[1].name, 'editedtag2')

@RoGryza RoGryza force-pushed the order-tags-in-test branch from b204fe7 to 866c7c5 Compare August 11, 2022 01:00
@RoGryza
Copy link
Contributor Author

RoGryza commented Aug 11, 2022

Done

@sissbruecker sissbruecker merged commit ee7ac77 into sissbruecker:master Aug 11, 2022
@RoGryza RoGryza deleted the order-tags-in-test branch September 14, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants