Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Netscape bookmarks file parsing #50

Closed
sissbruecker opened this issue Dec 31, 2020 · 0 comments · Fixed by #51
Closed

Improve Netscape bookmarks file parsing #50

sissbruecker opened this issue Dec 31, 2020 · 0 comments · Fixed by #51
Labels
enhancement New feature or request

Comments

@sissbruecker
Copy link
Owner

Currently linkding uses the beautiful-soup library to parse import files. Since the format is missing closing tags in many places this leads to a high number of nested tags / recursion when parsing the files. This leads to errors when parsing files with a large number of bookmarks.

I plan to replace beautiful-soup with a custom parser that does not have the nesting issue.
@sissbruecker sissbruecker added the enhancement New feature or request label Dec 31, 2020
sissbruecker pushed a commit that referenced this issue Dec 31, 2020
Implement custom Netscape file parser (#50)
a880fa9
sissbruecker pushed a commit that referenced this issue Dec 31, 2020
Add environment variable to configure request timeouts (#50)
a15c936
@sissbruecker sissbruecker mentioned this issue Dec 31, 2020
Merged
sissbruecker added a commit that referenced this issue Dec 31, 2020
@sissbruecker
Implement custom netscape file parser (#51)
779de41 
* Implement custom Netscape file parser (#50)

* Add environment variable to configure request timeouts (#50)

Co-authored-by: Sascha Ißbrücker <[email protected]>
@gingerbeardman gingerbeardman mentioned this issue Feb 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement custom netscape file parser sissbruecker/linkding
1 participant
@sissbruecker