Removed dictionaries from LinearDiscretizer, added bincenter #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me! @tawheeler ? |
tawheeler
approved these changes
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes discussed in #24 and #23
I decided to completely get rid of the dicts. Since D was already limited to be an Integer anyways, I think convert is actually the best way to support different key types. Moreover, if people want to use their own dicts/arrays on top of this to support mapping to some other type, that should not be too hard.
I also had to fix the lfactorial deprecation warning so that the tests would run in reasonable time.
Finally, there is one side effect of removing the dicts - if the user tries to decode an out-of-bounds key, a BoundsError is thrown instead of a KeyError. This seems ok to me.
This will directly affect some of the code I am using for my class, so I hope we can merge it ASAP. When it is done merging, can I add upper bounds to the dependency compats and tag and register v3.2.0?