Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explicitly restrict method params to avoid ambiguities in julia 1.2 #21

Merged
merged 2 commits into from
May 15, 2019
Merged

explicitly restrict method params to avoid ambiguities in julia 1.2 #21

merged 2 commits into from
May 15, 2019

Conversation

JeffBezanson
Copy link
Contributor

This allows tests to pass on julia v1.2, and should have no other effect.

@JeffBezanson JeffBezanson mentioned this pull request May 14, 2019
Closed
58 tasks
@coveralls
Copy link

coveralls commented May 14, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-26.7%) to 70.848% when pulling b731df6 on JeffBezanson:jb/1.2fix into 0ee9eea on sisl:master.

@tawheeler
Copy link
Contributor

What causes the big hit to coverage?

tawheeler
tawheeler approved these changes May 15, 2019
View reviewed changes
Copy link
Contributor

@tawheeler tawheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mykelk mykelk merged commit 74953b3 into sisl:master May 15, 2019
@ararslan ararslan mentioned this pull request Jul 23, 2019
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tawheeler tawheeler tawheeler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JeffBezanson @coveralls @tawheeler @mykelk