Moving target: upcoming version #61
Conversation
| modId = "minecraft" | ||
| type = "required" | ||
| versionRange = "[${mc},)" | ||
| ordering = "NONE" | ||
| side = "BOTH" | ||
|
|
||
| [[dependencies.${ modId }]] |
There was a problem hiding this comment.
i responded to the comment on the initial issue about this, i initially kept this tweak because that's how the default neoforge mod template does it, and intellij idea throws a warning if the spaces are present.
since it works fine anyways, rolled back the change for now.
There was a problem hiding this comment.
I'll put it in 1.21 instead and merge it over!
| @@ -76,7 +76,7 @@ public ChunkSummary(World world, WorldChunk chunk, int[] layerHeights, RegistryP | |||
| } else { // Blocks Movement or Has Non-Water Fluid. | |||
| if (foundFloor == null) { | |||
| if (carpetPos.getY() == y + 1) { | |||
| foundFloor = new LayerSummary.FloorSummary(carpetPos.getY(), biomePalette.findOrAdd(section.getBiomeEntry(x, carpetPos.getY(), z, world.getBottomY(), world.getTopY()).value()), blockPalette.findOrAdd(carpetBlock), world.getLightLevel(LightType.BLOCK, carpetPos), waterDepth, waterDepth == 0 ? 0 : world.getLightLevel(LightType.BLOCK, pos.up().up(waterDepth))); | |||
There was a problem hiding this comment.
for completeness, it's always good to confirm a surveyor update with a hoofprint update as well, just because atlas hides a lot of detail that could become wrong when touching the scanner. I think you're fine here because these are just renames, i can only assume the impl is the same.
There was a problem hiding this comment.
i just got an initial port going but i'm encountering the same rendering issues as in aa4. though considering the fact that hoofprint has way less parts i think i could reasonably try to figure it out, and maybe the solution will work for both
not quite done yet! the two unnamed methods in MixinServerWorld are gone and i'll have to track down what they were renamed to. other than that, it's mostly yarn renames.
lumiscosity
changed the title
Based off of #58 with the code review comments applied. This is the modified copy mentioned in sisby-folk/antique-atlas#246. Confirmed working on 1.21.2, 1.21.3 and 1.21.4-pre1.