Skip to content

Fix staticcheck issues#1390

Merged
sirupsen merged 2 commits intosirupsen:masterfrom
ashmckenzie:ashmckenzie/fix-staticcheck-issues
Jun 3, 2023
Merged

Fix staticcheck issues#1390
sirupsen merged 2 commits intosirupsen:masterfrom
ashmckenzie:ashmckenzie/fix-staticcheck-issues

Conversation

@ashmckenzie
Copy link
Copy Markdown
Contributor

This PR fixes the following go-staticcheck errors:

$ staticcheck
entry_test.go:39:49: should not use built-in type string as key for value; define your own type to avoid collisions (SA1029)
entry_test.go:59:50: should not use built-in type string as key for value; define your own type to avoid collisions (SA1029)
entry_test.go:63:50: should not use built-in type string as key for value; define your own type to avoid collisions (SA1029)
logrus_test.go:547:2: should merge variable declaration with assignment on next line (S1021)

@ashmckenzie ashmckenzie force-pushed the ashmckenzie/fix-staticcheck-issues branch from 5a6a3b7 to 80d649c Compare June 3, 2023 03:34
@ashmckenzie
Copy link
Copy Markdown
Contributor Author

ashmckenzie commented Jun 3, 2023

@sirupsen here's a very small PR to fix some go-staticcheck issues in a couple of tests 🙂

@sirupsen sirupsen merged commit 104b8b0 into sirupsen:master Jun 3, 2023
@sirupsen
Copy link
Copy Markdown
Owner

sirupsen commented Jun 3, 2023

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants