Skip to content

Commit

Permalink
Remove misleading coverage path configuration
Browse files Browse the repository at this point in the history
  • Loading branch information
Julien Debon committed Sep 12, 2018
1 parent 323f718 commit 5df4284
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 11 deletions.
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>com.github.sir4ur0n</groupId>
<artifactId>sonar-haskell-plugin</artifactId>
<version>1.0-SNAPSHOT</version>
<version>1.0</version>

<name>Sonar Haskell Plugin</name>
<description>Haskell Plugin for SonarQube based on HLint</description>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,27 +8,20 @@
import org.sonar.api.config.PropertyDefinition;

/**
*
* Configurable properties (visible in SonarQube admin, overridable in sonar-project.properties)
*/
@NoArgsConstructor(access = AccessLevel.PRIVATE)
public class HaskellProperties {

public static final String REPORT_PATH_KEY = "sonar.hlint.reportPath";
private static final String REPORT_PATH_DEFAULT = "hlintReport.json";
private static final String COVERAGE_REPORT_PATH_KEY = "sonar.coverage.reportPath";
private static final String COVERAGE_REPORT_PATH_DEFAULT = "coverage.out";

static List<PropertyDefinition> getProperties() {
return List(
PropertyDefinition.builder(REPORT_PATH_KEY)
.defaultValue(REPORT_PATH_DEFAULT)
.category("Haskell")
.name("hlint report path")
.description("hlint report relative path").build(),
PropertyDefinition.builder(COVERAGE_REPORT_PATH_KEY)
.defaultValue(COVERAGE_REPORT_PATH_DEFAULT)
.category("Haskell")
.name("coverage report Report path")
.description("coverage report relative path").build());
.description("hlint report relative path").build());
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ void testSonarHaskellPlugin() {

cut.define(context);

assertThat(context.getExtensions()).hasSize(6);
assertThat(context.getExtensions()).hasSize(5);
}

}

0 comments on commit 5df4284

Please sign in to comment.