-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typography #10
Merged
Merged
Typography #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements the basic Typography scale as discussed in #6.
Note: While button and helper text are documented under Typography in #6, they are out of scope for this issue and will be addressed when adding Button and Input respectively. They aren't stand-alone text styles.
Typography
Basic typography
The basic values for typography are set as followed:
$font-size-small
is used for both the.small
-class and<small>
-element as its default font style. Note that its unit isem
and notrem
.Headings
Heading, by default, scale entirely with the
$font-size-base
to provide consistency. The 6th heading level is the same size as a paragraph, from there the scale goes up by 25% of the base with each step, except for the 1st heading level which sees an increase of 50%.Marketing
The marketing stylings are a continuation of the headings. Unlike the headings, they are not based on the
$font-size-base
-value, but they do continue from the heading scale. The smallest marketing class provides text the same size as the 1st heading level.Lists
This pull request also introduces some class for removing the list style and placing list items inline.