spire: don't scan for supervisor keys during auto-launch #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This blocks pull requests if they contain merge commits.
celskeggs
previously approved these changes
Apr 20, 2020
511: Add bors-ng configuration r=cryslith a=cryslith - Configure bors-ng - Run CircleCI only during bors merges - Require branches to have linear git history Closes sipb#491. Co-authored-by: Lily Chung <[email protected]>
When launching an existing virtual cluster, don't attempt to authenticate to the supervisor with the pre-keysystem method of using the preseeded authorized ssh key. Doing so won't work because that ssh key is no longer authorized on the supervisor after the keysystem is set up. (Previously, it sometimes appeared to work when the keysystem-provided ssh keys were still loaded from a prior auto-install.) This also avoids unnecessarily pulling the host key from the keysystem and verifying it using the fingerprint displayed on the supervisor console; once the keysystem is set up the supervisor can authenticate itself using the CA.
cryslith
force-pushed
the
fix-497
branch
2 times, most recently
from
83360ac
to
c12588f
Compare
|
bors r+ |
|
Canceled. |
|
bors r+ (for science) |
hyades-bors bot
pushed a commit
that referenced
this pull request
Apr 21, 2020
513: spire: don't scan for supervisor keys during auto-launch r=cryslith a=cryslith When launching an existing virtual cluster, don't attempt to authenticate to the supervisor with the pre-keysystem method of using the preseeded authorized ssh key. Doing so won't work because that ssh key is no longer authorized on the supervisor after the keysystem is set up. (Previously, it sometimes appeared to work when the keysystem-provided ssh keys were still loaded from a prior auto-install.) This also avoids unnecessarily pulling the host key from the keysystem and verifying it using the fingerprint displayed on the supervisor console; once the keysystem is set up the supervisor can authenticate itself using the CA. Co-authored-by: Lily Chung <[email protected]>
|
no, stop that. bors r- |
|
Canceled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When launching an existing virtual cluster, don't attempt to
authenticate to the supervisor with the pre-keysystem method
of using the preseeded authorized ssh key.
Doing so won't work because that ssh key is no longer authorized
on the supervisor after the keysystem is set up.
(Previously, it sometimes appeared to work when the
keysystem-provided ssh keys were still loaded from a prior
auto-install.)
This also avoids unnecessarily pulling the host key
from the keysystem and verifying it using the fingerprint
displayed on the supervisor console; once the keysystem is
set up the supervisor can authenticate itself using the CA.
Checklist: