Add support for custom classes #505
Conversation
…use select takes care of rest..
Eliminate the customClasses prop in favor of adding custom classes directly from the dialog. This means that custom classes are backwards-compatible with existing roads (and interoperable with FireRoad), and all of the state is stored via conventional mechanisms in the road file/object.
Re-style the button, refactor form validation, re-word strings in dialog box
Use CSS classes (which now have !important, to override the default styling of the buttons) to get colors.
|
At this point, these are the remaining outstanding issues:
After these are resolved, this PR should be ready to merge. |
Make custom subject status override whether or not the subject ID is in the catalog (for units/hours calculation), suppress old ID and warnings for custom subjects
The dialog box is now triggered, but the form fields are not consistently populated (due to race conditions) and the actual subject is not updated on save.
|
Assuming that currently creating a custom subject with desired content works, can the "edit custom subject by clicking on it" functionality be split out into a separate PR so that this minimum viable feature can be merged? It's been a while since this was requested and having makeable, uneditable, but deletable custom subjects is much better than no custom subjects at all. |
Clearing the form before repopulating it is unnecessary (setting the values overwrites the previous values anyway) and created a race condition.
|
@eiis1000 Thanks for bumping this, and I'm really sorry about the delay on this PR. I looked at the remaining points and they turned out to be rather simple, so this should be ready for review/merge. I'll try to get someone to review this in the next week or so before merging. (Or, that person could be you!) |
|
Possible changes:
|
This fixes a bug where a dialog for editing a class cannot be opened twice if it was dismissed the first time by clicking outside.
Change the default from a gray color to the color corresponding to the course number of a subject.
Closes #423. Create a new dialog box for creating a custom class that is accessible from the search results box.