Shortened titles #401
Open
Shortened titles #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added shortening of titles based on OED abbreviations Added ellispsis-based truncation Truncation currently removes ability to break text at word boundaries (haven't found a way to resolve this).
Can now specify abbreviations that won't be abbreviated by a '.' No longer using line-clamp Fixed ascender text peaking in classes w/ >4 lines
Shortened titles now only appear when the longer title would be truncated Uses modified version of vue-line-clamp based on https://github.com/AndyDyer/vue-line-clamp/tree/add-options-change-fallback-logic
|
Fixes #401 |
npfoss
reviewed
Apr 10, 2020
src/utils/abbreviations.js
Outdated
| 'management': 'managem', | ||
| 'studies': 'stud', | ||
| 'biology': 'bio', | ||
| 'analysis': 'anal', |
There was a problem hiding this comment.
probably don't want this one
npfoss
reviewed
Apr 10, 2020
src/utils/abbreviations.js
Outdated
| 'advanced': 'adv', | ||
| 'research': 'res', | ||
| 'technology': 'tech', | ||
| 'management': 'managem', |
There was a problem hiding this comment.
maybe mgmt even? not sure how standard that is
npfoss
reviewed
Apr 10, 2020
Comment on lines
+4
to
+10
| 'and': nonAbbreviator + '&', | ||
| 'i': nonAbbreviator + '1', | ||
| 'ii': nonAbbreviator + '2', | ||
| 'iii': nonAbbreviator + '3', | ||
| 'iv': nonAbbreviator + '4', | ||
| 'v': nonAbbreviator + '5', | ||
| 'vi': nonAbbreviator + '6', |
There was a problem hiding this comment.
what's this nonabbreviator thing? does that mean v will become |5?
georgiashay
reviewed
Apr 10, 2020
| 'certificate': 'certif', | ||
| 'exercise': 'exerc', | ||
| 'physiological': 'physiol', | ||
| 'company': 'comp' |
There was a problem hiding this comment.
could be confused with computer
Changed/removed some abbreviations Fixed linter errors in vue-line-clamp.js
…into shortened-titles
georgiashay
requested changes
May 10, 2020
|
It may be a good idea to use the standard abbreviations for transcripts given by the Registrar's Office. |
miriam-rittenberg
force-pushed
the
shortened-titles
branch
from
0f59bcf to
eb71773
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nonAbbreviatorto an abbreviation to have it not followed by a'.'in shortened titlesSet the
Classcomponent'suseShortenedTitletotruein order to have all classes display shortened titles, even if they aren't truncatedI don't have the full list of words in class names that are missing abbreviations because my MacBook's battery died. When I get access to the files again, I will post them.