Make it clear audit classes can be dragged and clicked #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into cdr-audit-hover
npfoss
approved these changes
Mar 1, 2020
miriam-rittenberg
pushed a commit
that referenced
this pull request
Oct 21, 2020
* Add hover and grabby mouse icon to leaf reqs. * Add hover and grab cursor to leafs using v-ifs * Add color change on hover. Fix cursor icon changing correctly. * Remove draggable from requirement * Add hover to entire leaf, not just text. * Adjust dash position to match text. Clipboard icon slightly unaligned now. * Move canDrag and classInfo to mixin. * Add proper checking for draggable audit leaf. * Fix class drag issue. TypeError still present. * Fix class drag issue. * lint Co-authored-by: Nate Foss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #127
The audit reqs that can be dragged now elevate when hovered over by the mouse. The mouse cursor also changes to a grabby hand.
ClassInfo and canDrag have been moved from Requirement into a mixin called classInfo so that they can be used by the v-hover in the audit. They have also changed from computed to methods to allow a req to be passed into them. As such, the usages of classInfo and canDrag within Requirement now pass the req prop as a parameter.
The icon next to the requirement on the leaf level of the tree is no longer its own template but rather within the label slot. This was so the hover encompasses both the icon and text which makes it much more apparent. Some css styling was added so that the icon would be on the left side and be centered with the text of the label.