Reset fullfillmentNeeded for new Roads #382
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttpcodes
force-pushed
the
new-road-reqs
branch
3 times, most recently
from
a28194c to
cff08d3
Compare
ttpcodes
force-pushed
the
new-road-reqs
branch
from
cff08d3 to
fb31483
Compare
georgiashay
requested changes
Mar 1, 2020
| @@ -295,6 +295,8 @@ export default { | |||
| _this.$store.commit('setRetrieved', newRoad); | |||
| }); | |||
| } else if (newRoad !== '') { | |||
| // Reset fulfillmentNeeded so that new Roads still call FireRoad to check fulfillment. | |||
| this.$store.commit('resetFulfillmentNeeded'); | |||
There was a problem hiding this comment.
This is calling update fulfillment twice when you create a new road while logged in (once on creation, once on name change). This should go specifically after a new road is added instead (in addRoad on MainPage).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resets
fulfillmentNeededevery time we switch to a differentRoadinCourseRoad. This works around the issue of newRoadsthat are switched to having theirfullfillmentNeededbeing set to none and thus not having theirFulfillmentget reset duringupdateFulfillment.This PR closes #344 and closes #366.