Expected hours tooltip #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npfoss
reviewed
Feb 19, 2020
|
They have one in Vuetify 2, but the one for 1.5 doesn't seem like it can easily support merged cells + vertical headers. I put it in the 1.5 data table and it looks okay-ish, but I can't make it small so I honestly like the raw html one better. If we can figure out how to make it small it would look better though. |
|
Hmm I see... Alright can you just put it back to the raw html version and I'll spend some time styling it manually? Sorry for the wild goose chase, but you're right, Vuetify is worse here |
npfoss
approved these changes
Mar 10, 2020
|
Looks good to me |
miriam-rittenberg
pushed a commit
that referenced
this pull request
Oct 21, 2020
* Tooltip shows table of hours broken down by class and quarter * Only show one quarter if classes are only in one quarter * Test putting in vuetify table * lint * Remove vuetify table * styling for table * lint, remove unused Co-authored-by: Nate Foss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #224
Shows a tooltip table that breaks down expected hours by quarter and subject. Useful to see how hard each quarter will be, and also to see where large amounts of hours come from in your schedule.