Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enter key submit #375

Merged
merged 6 commits into from
Feb 29, 2020
Merged

Enter key submit #375

merged 6 commits into from
Feb 29, 2020

Conversation

georgiashay
Copy link
Collaborator

Closes #202

  • enter on class search opens class info card with first result
  • enter in major v-autocomplete already opens result once you reach the first space in result
  • enter in renaming a road submits dialog
  • enter in manual progress number input submits manual progress
  • enter in import roads name field imports the road

Copy link
Collaborator

@npfoss npfoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

made one small tweak -- if you agree, go ahead and merge

@npfoss npfoss merged commit c1c7a19 into master Feb 29, 2020
@npfoss npfoss deleted the enter-key-submit branch February 29, 2020 21:42
miriam-rittenberg pushed a commit that referenced this pull request Oct 21, 2020
* Open first search result on enter

* Pressing enter renames a road

* Submit manual progress on enter

* Import road on enter in title field

* Don't import road if another road has the same name already

* show error if import name not unique

Co-authored-by: Nate Foss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit cases where enter key should "submit form"
2 participants