-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes obsolete independent_bn_bias argument #221
Removes obsolete independent_bn_bias argument #221
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #221 +/- ##
========================================
+ Coverage 7.50% 7.52% +0.02%
========================================
Files 58 58
Lines 5982 5965 -17
Branches 1018 1012 -6
========================================
Hits 449 449
+ Misses 5496 5479 -17
Partials 37 37 ☔ View full report in Codecov by Sentry. |
I would keep it on pause while the examples in the notebooks folder are not updated because currently there is nnsysident there and it actually uses this argument |
After discussing we decided to remove the example later and in the repositories, who depend on this parameter, they might specify the commit to inherit. There is the |
Merge #221 226 before merging this PR to avoid merge conflicts |
@MaxFBurg I guess its now black and should be fine after |
Addressing #219