WIP: Drop node 12, add node 18 #195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failure from
FormDatais caused byjsdom-global, which removes it in the cleanup.See https://github.com/rstacruz/jsdom-global/blob/master/keys.js#L122
The
jsdom-globallooks pretty dead. A quick fix would be to fork it and improve it to not destroy the new globals in Node 18.... or maybe there are better libraries out there now.The
FileReaderfailures are because theFileReaderAPI is not available in node, and newly added globalBlobsupport is enabling the codepaths that useFileReader.nodejs/node#41270
We should probably learn how to read blobs in a node native way, not using
FileReader, and save that for browsers.