-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add Dockerfile and Docker image build action #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamyDjemai
force-pushed
the
ci/dockerfile
branch
from
November 8, 2024 16:56
70541e8
to
4d1d791
Compare
benley
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you! Hopefully the arm64 build finishes successfully, that looks like it's going to take a while.
Yep, the ARM64 binary is currently built with emulation using QEMU, native ARM64 runners won't be available until early 2025 😕 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3 (and #2?).
This adds a Dockerfile and a GitHub Action that builds and pushes the Docker image to GitHub Container Registry. The Docker image contains a statically-linked
tailscale-manager
binary, and is built using GitHub Actions cache: an initial build lasts around 15 minutes 🤯, whereas subsequent builds last less than 30 seconds, given that Cabal dependencies haven't changed.A test image is available at
ghcr.io/samydjemai/tailscale-manager:pr-1
, and there are some workflow runs on my fork PR: SamyDjemai#1I've added an example of how the image can be used in other Docker images, as well as some documentation in
README.md
.Thanks for the useful tool :)