-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add writ tests #39
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- changed make target for test to depend on a wasm module. That way we can test both release and debug in the CI. - If I spied rust unit tests, I added those to the make target. We could also consider gtests for C++ examples in the future. - only run pages when files change
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,11 +14,12 @@ wasm: | |
cargo wasi build --lib $(RELFLAGS) | ||
|
||
.PHONY: test | ||
test: debug | ||
test: wasm | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similar to the above comment, but opposite. Changing this dependency to "wasm" implies the target will always be built in debug mode because the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. hrm. I think I'm going to remove any dependency then. The thing I was trying to refactor is that when it depends on debug, it builds debug even after having just built a release (which is the module I actually want to test). |
||
writ \ | ||
-e "2022-07-30" \ | ||
--wit $(MODULE).wit target/wasm32-wasi/debug/$(MODULE).wasm next-saturday \ | ||
"2022-07-23" | ||
cargo wasi test | ||
@echo PASS | ||
|
||
.PHONY: clean | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing this dependency to
power.wasm
implies that the test will always be built in release mode because theDBGFLAGS
variable won't be set. Perhaps we should setDBGFLAGS
globally and then have therelease:
target clear it?