Merge pull request #62 from aliraza556/fix-latest-trade-detail-interface

Fix: Update Latest Trade Detail WebSocket Event Interface
singlesly · Jan 22, 2024 · 8ac118d · 8ac118d
2 parents 3f3e134 + e6098c2
commit 8ac118d
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 9 deletions.
diff --git a/src/bingx-socket/bingx-market-socket-stream.ts b/src/bingx-socket/bingx-market-socket-stream.ts
@@ -16,9 +16,9 @@ import { HeartbeatInterface } from 'bingx-api/bingx-socket/interfaces/heartbeat.
 import {
   LatestTradeEvent,
   MarkerSubscription,
-  MarkerWebsocketEvents,
+  MarketWebsocketEvents,
   SubscriptionType,
-} from 'bingx-api/bingx-socket/events/marker-websocket-events';
+} from 'bingx-api/bingx-socket/events/market-websocket-events';
 
 export class BingxMarketSocketStream {
   private forceClose$ = new BehaviorSubject<boolean>(false);
@@ -36,7 +36,7 @@ export class BingxMarketSocketStream {
   }
 
   private async connect(url: URL): Promise<void> {
-    const socket$ = webSocket<MarkerWebsocketEvents | MarkerSubscription>({
+    const socket$ = webSocket<MarketWebsocketEvents | MarkerSubscription>({
       deserializer: (e) => new BingxWebsocketDeserializer().deserializer(e),
       serializer: (e) => new BingxWebsocketSerializer().serializer(e),
       url: url.toString(),

diff --git a/src/bingx-socket/events/index.ts b/src/bingx-socket/events/index.ts
@@ -4,11 +4,11 @@ export {
   SubscriptionType,
   LatestTradeEvent,
   TradeDataType,
-  MarkerWebsocketEvents,
+  MarketWebsocketEvents,
   Price,
   Volume,
   MarkerWebsocketEventCode,
   IsMarketMaker,
   TransactionTimeInMillis,
   MarkerSubscription,
-} from './marker-websocket-events';
+} from './market-websocket-events';
diff --git a/...-socket/events/marker-websocket-events.ts → ...-socket/events/market-websocket-events.ts b/...-socket/events/marker-websocket-events.ts → ...-socket/events/market-websocket-events.ts
@@ -19,16 +19,21 @@ export type TradeDataType = `${TradingPair}@trade`;
 
 export type SubscriptionType = TradeDataType;
 
-export interface MarkerWebsocketEvents {
+export interface MarketWebsocketEvents {
   code: MarkerWebsocketEventCode;
   dataType: SubscriptionType;
 }
 
-export interface LatestTradeEvent extends MarkerWebsocketEvents {
-  dataType: TradeDataType;
+export interface TradeDetail {
   T: TransactionTimeInMillis;
   s: TradingPair;
   m: IsMarketMaker;
   p: Price;
-  v: Volume;
+  v: Volume; // Assuming 'q' represents volume
+}
+
+export interface LatestTradeEvent extends MarketWebsocketEvents {
+  code: MarkerWebsocketEventCode;
+  dataType: TradeDataType;
+  data: TradeDetail[];
 }