Merge pull request #73 from singlesly/feat_cancel_order

fix: add symbol prop to cancel order
singlesly · Feb 15, 2024 · 67f232d · 67f232d
2 parents aecf37c + f523797
commit 67f232d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/bingx-client/services/trade.service.ts b/src/bingx-client/services/trade.service.ts
@@ -34,9 +34,13 @@ export class TradeService {
     );
   }
 
-  public async cancelOrder(orderId: string, account: AccountInterface) {
+  public async cancelOrder(
+    orderId: string,
+    symbol: string,
+    account: AccountInterface,
+  ) {
     return this.requestExecutor.execute(
-      new BingxCancelOrderEndpoint(account, orderId),
+      new BingxCancelOrderEndpoint(account, orderId, symbol),
     );
   }
 

diff --git a/src/bingx/endpoints/bingx-cancel-order-endpoint.ts b/src/bingx/endpoints/bingx-cancel-order-endpoint.ts
@@ -11,6 +11,7 @@ export class BingxCancelOrderEndpoint<R = unknown>
   constructor(
     account: AccountInterface,
     private readonly orderId: string,
+    private readonly symbol: string,
   ) {
     super(account);
   }
@@ -21,6 +22,7 @@ export class BingxCancelOrderEndpoint<R = unknown>
   parameters(): SignatureParametersInterface {
     return new DefaultSignatureParameters({
       orderId: this.orderId,
+      symbol: this.symbol,
     });
   }
   path(): string {