[python] Update the MultiscaleImage to match somacore API changes
#3262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jp-dark
requested review from
aaronwolen,
ktsitsi,
ivirshup,
XanthosXanthopoulos and
nguyenv
jp-dark
commented
Oct 30, 2024
jp-dark
commented
Oct 30, 2024
jp-dark
force-pushed
the
dark/multiscale-image/sc-57977
branch
2 times, most recently
from
ab5b3b8 to
497e219
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dark/somacore-1.0.23 #3262 +/- ##
=======================================================
Coverage ? 83.74%
=======================================================
Files ? 51
Lines ? 5542
Branches ? 0
=======================================================
Hits ? 4641
Misses ? 901
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jp-dark
force-pushed
the
dark/multiscale-image/sc-57977
branch
from
1b1e736 to
a50d8cf
Compare
jp-dark
force-pushed
the
dark/multiscale-image/sc-57977
branch
from
a50d8cf to
b000c29
Compare
jp-dark
added a commit
that referenced
this pull request
Nov 1, 2024
…#3262) * Directly take the `CoordinateSpace` as a creation parameter. * Remove confusing `image_type` property/creation parameter. Use `data_axis_order` instead which uses the axis names the user provided. * Create the first resolution level when creating the `MultiscaleImage`. * Require the `add_new_level` to only add images smaller than the base (level=0) image. * Add a `set` method for adding images that exist outside of SOMA. * Add a property to check the number of channels in the image. * Replace public facing `ImageProperties` class with internal `_LevelProperties` class.
jp-dark
added a commit
that referenced
this pull request
Nov 1, 2024
* Update Scene subcollection API - Make subcollection always a positional argument (for consistency). - Fix docstrings for `create` methods (no default value for subcollection). * [python] Update the `MultiscaleImage` to match `somacore` API changes (#3262) - Directly take the `CoordinateSpace` as a creation parameter. - Remove confusing `image_type` property/creation parameter. Use `data_axis_order` instead which uses the axis names the user provided. - Create the first resolution level when creating the `MultiscaleImage`. - Require the `add_new_level` to only add images smaller than the base (level=0) image. - Add a `set` method for adding images that exist outside of SOMA. - Add a property to check the number of channels in the image. - Replace public facing `ImageProperties` class with internal `_LevelProperties` class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the companion TileDB-SOMA changes for single-cell-data/SOMA#238. It consists of major changes to the
MultiscaleImageimplementation.Do NOT merge before single-cell-data/SOMA#238.