Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Add support for floats in axis query #138

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

thetorpedodog
Copy link
Contributor

@thetorpedodog thetorpedodog commented Feb 22, 2023

As of recently 1, TileDB-SOMA now supports floats when indexing dataframes. We should no longer forbid them in axis queries.

Context: issue single-cell-data/TileDB-SOMA#960

As of recently [1], TileDB-SOMA now supports floats when indexing
dataframes.  We should no longer forbid them in axis queries.

[1]: single-cell-data/TileDB-SOMA#968
Copy link
Member

@bkmartinjr bkmartinjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@johnkerl johnkerl changed the title python: Add support for floats in axis query. [python] Add support for floats in axis query Feb 22, 2023
Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@thetorpedodog thetorpedodog merged commit 0e448f3 into main Feb 22, 2023
@thetorpedodog thetorpedodog deleted the we-support-floats-now branch February 22, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants