[python] Remove the Comparable protocol
#129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't use it anymore, and it is not useful for static analysis (you only need to implement a subset of the methods to support all comparisons) nor at runtime (every object implements all of the `__xx__` methods, but most return `NotImplemented`, meaning that `isinstance(anything, Comparable)` was always true even for things that were not comparable, like regular old `object()`.
thetorpedodog
requested review from
mlin,
johnkerl,
bkmartinjr and
atolopko-czi
johnkerl
approved these changes
Feb 15, 2023
bkmartinjr
approved these changes
Feb 15, 2023
johnkerl
changed the title
Comparable protocol.Comparable protocol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't use it anymore, and it is not useful for static analysis (you only need to implement a subset of the methods to support all comparisons) nor at runtime (every object implements all of the
__xx__methods, but most returnNotImplemented, meaning thatisinstance(anything, Comparable)was always true even for things that were not comparable, like regular oldobject().