-
Notifications
You must be signed in to change notification settings - Fork 973
feat(keyboard): support for customize onKey events, original PR #2345 #2368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
70ad028
Feat: support for prevent keyboard events
fd9d26a
Chore: added experimental mark
9f5a9d4
Chore: added experimental mark in constructors for onKeyPressed param
6cbe19a
Chore: improved example documentation about onKeyPressed parameter
82f0411
Chore: dart format
2804cc0
Chore: added supported platforms for onKeyPressed param
0e7b8ee
Chore: fix nullable operation when onKeyPressed will be executed
22a6283
Chore: removed config ref in onKeyPressed docs comments
8e9489c
Chore: added a descriptive var for onKeyPressed example code
3c414b7
Chore: improved doc comment in _onKeyEvent function
1363104
Chore: improved docs about onKeyPressed param
2849930
Chore: dart format
b8c2638
Chore: updated supported platforms warnings for onKeyPressed
6cba40e
Chore: fix last update about docs in onKeyPress property
45d6425
Chore: improve docs about onKeyPressed
25db6a0
chore: merge origin/master and fix conflicts with release/v11
EchoEllet addb7a1
docs(changelog): update CHANGELOG.md to reflect the change
EchoEllet 8fe448d
docs: indicate that the new property is supported on desktop devices …
EchoEllet 5fc7ea7
docs: indicate that the new property is supported on desktop devices …
EchoEllet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Space between the
onKeyPressed
and the docs comment.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's purely a matter of visual taste. I prefer it this way. It's clear that in the end in Markdown this is irrelevant and will remove any spacing I put in.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's though we have different tastes, and that makes the project docs style slightly inconsistent, I'm trying to use something that's commonly used in the project and known by most developers to make it easier to adapt.
This style is also quite common. It's used in Flutter (example code) and Dart (related Effective Dart section).
It's irrelevant to the final result but not necessarily to the project code.
The if check code below has 3 spaces which might not make it formatted properly.