Stuck magnifying glass

[vargab95]

Is there an existing issue for this?

• I have searched the existing issues

Flutter Quill version

10.8.5

Steps to reproduce

1. Open a QuillEditor.basic with some text
2. Long press on a word
3. Start to pull the right side up

Expected results

The magnifying glass and the selection is adjusted to the new position of the marker.

Actual results

Markers do disappear and the magnifying glass is stuck until the app is restarted.

Additional Context

Screenshots / Video demonstration

Logs

[Paste your logs here]

[EchoEllet]

I'm thinking about reverting the magnifier feature completely (#2026) in v11 with all related changes, too many regressions, bugs, and workarounds (#2376, #2153, #2128, #2124, #2049, #2391, #2401), it made changes to many parts of the API, removed an assert check to dodge issues, not implemented cleanly.

[vargab95]

If someone faces the same issue, a workaround could be to add magnifierConfiguration: const TextMagnifierConfiguration(), to the QuillEditorConfigurations.

[mtallenca]

I have many users enjoying this feature - but have a couple dozen or so stuck magnifier complaints as well. I took a look at the code and there are a couple of paths where the selectionOverlay is dismissed via a call to hide() that takes care of the toolbar menu but not the magnifier. When hide() is called directly, not in the regular disposal path, the selectionOverlay is removed before the call to remove the magnifier. In those cases, the magnifier will be left floating on the screen.

We're testing a branch of 10.8.5 now with a simple fix for this. Try out the following override:

  flutter_quill:
    git:
      url: https://github.com/mtallenca/flutter-quill
      ref: 10.8.5_magnification

[EchoEllet]

The magnifier feature has been removed in 11.0.0-dev.20. @mtallenca and @vargab95 Could you confirm whether this version fixed the encountered issue? Thanks!

[vargab95]

Yes, it is fine for me.

[EchoEllet]

Thanks for confirming!

I have many users enjoying this feature - but have a couple dozen or so stuck magnifier complaints as well.

Sorry for the issues. We will be more responsible and cautious for reviewing PRs.

[mtallenca]

Removal of the magnifier does not impact our production app. It was a nice feature, hopefully a cleaner solution can be found.