Force linux command to have exit code 0 #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sindresorhus any input on this? If you're too busy to handle linux PRs I'm happy to help. |
|
The Linux part of the codebase was completely rewritten. I don't think this is an issue anymore. |
|
Sounds good! Thank you @sindresorhus, I appreciate that you do reply to every single PR and issue, that must be quite some work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't wanna make more linux related issues so I found a fix for https://github.com/sindresorhus/wallpaper-cli/issues/7.
I found that the error was thrown by
child_processbecause the exit code of the command was 1 (even tho it's kind of intended). I forced it to have exit code 0 withecho, although it's not the most elegant solution. I'm open to other solutions.