Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path: add bracketNotation option #926

Merged
merged 7 commits into from
Aug 8, 2024

Conversation

Emiyaaaaa
Copy link
Collaborator

closed #921

we can change default style on V5 if need.

source/paths.d.ts Outdated Show resolved Hide resolved
@Emiyaaaaa
Copy link
Collaborator Author

Emiyaaaaa commented Aug 1, 2024

I notice that Get can accept a 'mixed' path like 0[0].0 in addition to these two styles. so we should add a new style more, or just make Paths output all style?

@sindresorhus
Copy link
Owner

I notice that Get can accept a 'mixed' path like 0[0].0 in addition to these two styles. so we should add a new style more, or just make Paths output all style?

Neither. It doesn't make sense to support such a mixed style.

source/paths.d.ts Outdated Show resolved Hide resolved
@Emiyaaaaa Emiyaaaaa marked this pull request as draft August 8, 2024 07:11
@Emiyaaaaa Emiyaaaaa marked this pull request as ready for review August 8, 2024 10:29
@Emiyaaaaa Emiyaaaaa changed the title Path: add style option Path: add bracketNotation option Aug 8, 2024
@sindresorhus sindresorhus merged commit 3b15a94 into sindresorhus:main Aug 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with Paths type
2 participants