-
-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SetRequired
and SetOptional
types
#48
Add SetRequired
and SetOptional
types
#48
Conversation
👍 Some other name ideas: It's really too bad that the built-in |
You need to add the types to the readme. https://github.com/sindresorhus/type-fest/blob/master/.github/contributing.md |
This expresses intent better and couples the sister types make definition file
Require
and Optionalize
typesSetRequired
and SetOptional
types
@sindresorhus thank you for the feedback I went ahead and resolved each line item. I'd appreciate additional feeedback you might have :) Also did you prefer that I squash all the commits to clean it up? Wasn't sure, the readme didn't mention it. |
479173a
to
1c76afe
Compare
Looks good now. Thanks :) |
Now that I'm looking at it maybe SomeRequired and SomeOptional would be better names? Couples the two, as it should and expresses intent pretty well.Edit: changed to SetRequired and SetOptional per feedback from sindresorhus