Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate PromiseValue type #322

Merged
merged 2 commits into from
Nov 21, 2021
Merged

Deprecate PromiseValue type #322

merged 2 commits into from
Nov 21, 2021

Conversation

liuhanqu
Copy link
Contributor

@liuhanqu liuhanqu commented Nov 19, 2021

Fix #308

@liuhanqu liuhanqu mentioned this pull request Nov 19, 2021
@sindresorhus
Copy link
Owner

You did not do what I commented in the issue. Also, please link to the issue in the form of Fix #123 in the pull request description.

@liuhanqu
Copy link
Contributor Author

  1. add @deprecated
  2. remove from doc

It's not right ?

@sindresorhus sindresorhus changed the title Remove PromiseValue type Deprecate PromiseValue type Nov 21, 2021
@sindresorhus sindresorhus merged commit ab7386d into sindresorhus:main Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate PromiseValue
2 participants