Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change outDir in readme #5

Closed
wants to merge 1 commit into from
Closed

Change outDir in readme #5

wants to merge 1 commit into from

Conversation

fregante
Copy link
Contributor

@fregante fregante commented Mar 14, 2019

outDir is already dist in the config.

By the way, this outDir in your config somehow causes TS not to produce any files (if the folder is missing) like in fregante/delegate-it@62fc191 -> fregante/delegate-it@975d227

tsc --outDir dist and the local tsconfig.json files work correctly, so this looks like an extends-specific bug. Perhaps it should be dropped until the bug it's fixed in TS

outDir is already dist in the config
@sindresorhus
Copy link
Owner

By the way, this outDir in your config somehow causes TS not to produce any files (if the folder is missing) like in fregante/delegate-it@62fc191 -> fregante/delegate-it@975d227

Yes, this is a TS bug: microsoft/TypeScript#29172

outDir is already dist in the config.

I included it in the the readme exactly because of the TS bug. But in hindsight, better to just disable the outDir in the config for now until it's fixed in TS.

fregante added a commit to nickytonline/refined-github that referenced this pull request Mar 26, 2019
Related to sindresorhus/tsconfig#5

`outDir` was blocking the emission of files and effectively acting as a `noEmit: true`

Now that property is removed, `webpack` was emitting a .d.ts for every typescript file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants