Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when no process are found in non-english Windows #19

Merged
merged 3 commits into from
Jul 7, 2019

Conversation

githoniel
Copy link
Contributor

@githoniel githoniel commented Apr 4, 2019

Fixes #11

cmd use other encoding and error message according to system language.
error message will not start with Info in other language.
even worse the encoding maybe wrong, for example, it will use gbk as default in chinese Windows, and the message is un-readable unless you run chcp 65001 first to change cmd encoding to UTF-8

So i change to start with " to make it work

@sindresorhus
Copy link
Owner

except we're using the /nh "no headers" option at the moment. But I guess we can get rid of that and just let the CSV parser remove the headers.

?

@sindresorhus
Copy link
Owner

The PR needs a better title.

@githoniel githoniel changed the title fix when no process no found in other language fix error when no process are found in none-english Windows Jun 23, 2019
@sindresorhus sindresorhus changed the title fix error when no process are found in none-english Windows Fix error when no process are found in non-english Windows Jul 7, 2019
@sindresorhus sindresorhus merged commit a5dd15b into sindresorhus:master Jul 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non English locale incompatibility
3 participants