Improve performance #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #10
fityannugroho
approved these changes
Nov 12, 2023
There was a problem hiding this comment.
I have tested it on my own device, and I think it is already fast enough.
str.matchAll: 0.663ms
matches: 10.594ms
matches-t500: 84.115ms
str.match: 0.469ms
firstMatch: 10.175ms
firstMatch-t500: 106.647ms
Count chars: 23749
Count rows: 405
Count matches: 363 363 363 363 363 363
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10
Apparently, creating a
vmcontext is very expensive. It now reuses the context. This should in theory be safe as JavaScript is single-threaded, so two functions cannot execute, for example,firstMatchat the same time. But it does make me think whether there's anything I'm missing.// @fityannugroho