Add ambiguousIsNarrow option
#34
Merged
+50
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seachicken
commented
Nov 20, 2021
Comment on lines
-33
to
-35
| // Surrogates | ||
| if (codePoint > 0xFFFF) { | ||
| index++; |
There was a problem hiding this comment.
Surrogate pairs have already been solved here
index.js
Outdated
| @@ -1,8 +1,8 @@ | |||
| import stripAnsi from 'strip-ansi'; | |||
| import isFullwidthCodePoint from 'is-fullwidth-code-point'; | |||
| import eaw from 'eastasianwidth'; | |||
There was a problem hiding this comment.
Suggested change
| import eaw from 'eastasianwidth'; | |
| import eastAsianWidth from 'eastasianwidth'; |
index.d.ts
Outdated
| @@ -17,4 +17,8 @@ stringWidth('\u001B[1m古\u001B[22m'); | |||
| //=> 2 | |||
| ``` | |||
| */ | |||
| export default function stringWidth(string: string): number; | |||
| export interface Options { | |||
| ambiguousIsNarrow: boolean; | |||
There was a problem hiding this comment.
Needs a proper doc comment.
https://github.com/sindresorhus/typescript-definition-style-guide
sindresorhus
changed the title
ambiguousIsNarrow option
sindresorhus
reviewed
Jan 8, 2022
sindresorhus
reviewed
Jan 8, 2022
sindresorhus
reviewed
Jan 8, 2022
index.js
Outdated
| width += 2; | ||
| break; | ||
| case 'A': | ||
| width += options.ambiguousIsNarrow ? 1 : 2; |
There was a problem hiding this comment.
options.ambiguousIsNarrow ? 1 : 2 should be moved out of the loop, into a variable.
Co-authored-by: Sindre Sorhus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1
I switched to this library which can resolve ambiguous characters.
In East Asian legacy character encodings (e.g. Japanese environment), ambiguous characters are resolved as full-width by default. We can set the option to make them half-width characters.