Support combining characters (#12)

sindresorhus · Jul 18, 2017 · 2af7be5 · 2af7be5
1 parent 175b26f
commit 2af7be5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/index.js b/index.js
@@ -14,13 +14,13 @@ module.exports = str => {
 	for (let i = 0; i < str.length; i++) {
 		const code = str.codePointAt(i);
 
-		// Ignore control characters
-		if (code <= 0x1F || (code >= 0x7F && code <= 0x9F)) {
+		// Ignore control characters & combining characters
+		if (code <= 0x1F || (code >= 0x7F && code <= 0x9F) || (code >= 0x300 && code <= 0x36F)) {
 			continue;
 		}
 
 		// Surrogates
-		if (code >= 0x10000) {
+		if (code > 0xFFFF) {
 			i++;
 		}
 

diff --git a/test.js b/test.js
@@ -21,6 +21,6 @@ test('ignores control characters', t => {
 	t.is(m('\u001B'), 0);
 });
 
-test.failing('handles combining characters', t => {
+test('handles combining characters', t => {
 	t.is(m('x\u0300'), 1);
 });