Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support non-ASCII characters in paths #19

Closed
birjj opened this issue Sep 22, 2022 · 2 comments · Fixed by #20
Closed

Support non-ASCII characters in paths #19

birjj opened this issue Sep 22, 2022 · 2 comments · Fixed by #20

Comments

@birjj
Copy link
Contributor

birjj commented Sep 22, 2022

This project claims that

Forward-slash paths can be used in Windows as long as they're not extended-length paths and don't contain any non-ascii characters.

However, the linked SuperUser answer does not mention the non-ASCII limitation. The official documentation also makes no mention of it, instead noting that

File I/O functions in the Windows API convert "/" to "\" as part of converting the name to an NT-style name, except when using the "\\?\" prefix as detailed in the following sections.

(this quote used to be on the documentation site linked in the SuperUser answer, but has since been moved to the "Maximum File Path Limitation" page)

Is there any documentation or examples to support the non-ASCII limitation in this project? From my own anecdotal testing it appears that paths with non-ASCII characters and forward slash path separators are supported in Windows and Node.js.

If there is no documentation, could this project be updated to support them? It appears to cause many problems in projects that rely on it, e.g. facebook/docusaurus#8124, gatsbyjs/gatsby#19600, and SAP/ui5-tooling#469, amongst others.
@birjj birjj mentioned this issue Sep 22, 2022
Closed
7 tasks
birjj added a commit to birjj/slash that referenced this issue Sep 26, 2022
@birjj
fix: remove non-ASCII limitation
9a020ab 
Fixes sindresorhus#19
I have been unable to find documentation for the non-ASCII limitation,
and anecdotal testing have shown forward slashes to be supported in
non-ASCII paths. See sindresorhus#19 for more information
@birjj birjj mentioned this issue Sep 26, 2022
Merged
birjj added a commit to birjj/docusaurus that referenced this issue Sep 27, 2022
@birjj
fix: remove non-ASCII limitation for path normalization
df60ebd 
See sindresorhus/slash#19 for discussion on limitation in the originating package
This updates the integrated function to match sindresorhus/slash after sindresorhus/slash#20
@birjj birjj mentioned this issue Sep 27, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove non-ASCII limitation birjj/slash
2 participants
@birjj and others