Require Node.js 18+ #100
Merged
Require Node.js 18+ #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
commented
Jan 3, 2025
fregante
commented
Jan 3, 2025
| @@ -11,15 +11,6 @@ function deserializeNonError(t, value) { | |||
| t.is(deserialized.message, JSON.stringify(value)); | |||
| } | |||
|
|
|||
| // TODO: Replace with plain `new Error('outer', {cause: new Error('inner')})` when targeting Node 16.9+ | |||
There was a problem hiding this comment.
There's another TODO, but the mentioned API is still marked as "experimental"
https://nodejs.org/api/stream.html#streamisreadablestream
Lines 101 to 105 in a2df3ae
alexandresoro
pushed a commit
to alexandresoro/ouca-backend
that referenced
this pull request
Jan 5, 2025
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [serialize-error](https://github.com/sindresorhus/serialize-error) | dependencies | major | [`11.0.3` -> `12.0.0`](https://renovatebot.com/diffs/npm/serialize-error/11.0.3/12.0.0) | --- ### Release Notes <details> <summary>sindresorhus/serialize-error (serialize-error)</summary> ### [`v12.0.0`](https://github.com/sindresorhus/serialize-error/releases/tag/v12.0.0) [Compare Source](sindresorhus/serialize-error@v11.0.3...v12.0.0) ##### Breaking - Require Node.js 18+ ([#​100](sindresorhus/serialize-error#100)) [`98bbe4e`](sindresorhus/serialize-error@98bbe4e) - Avoid breaking with bad custom constructors ([#​104](sindresorhus/serialize-error#104)) [`e593d37`](sindresorhus/serialize-error@e593d37) ##### Improvements - Add support for `AggregateError` ([#​103](sindresorhus/serialize-error#103)) [`b6ff2eb`](sindresorhus/serialize-error@b6ff2eb) - Tighten Error determination ([#​101](sindresorhus/serialize-error#101)) [`7fc2898`](sindresorhus/serialize-error@7fc2898) ##### Fixes - Stop making non-Error properties non-enumerable ([#​102](sindresorhus/serialize-error#102)) [`1d8395b`](sindresorhus/serialize-error@1d8395b) - Fix return type for `unknown` input ([#​105](sindresorhus/serialize-error#105)) [`64ce883`](sindresorhus/serialize-error@64ce883) *** </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45MC40IiwidXBkYXRlZEluVmVyIjoiMzkuOTAuNCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19--> Reviewed-on: https://git.tristess.app/alexandresoro/ouca/pulls/444 Reviewed-by: Alexandre Soro <[email protected]> Co-authored-by: renovate <[email protected]> Co-committed-by: renovate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lint is failing, package hasn't been updated in a while.
I tried to keep it non-breaking but due to the
getAllCommentsbug, there's no working XO version compatible with Node 14+Before releasing a new major, I'll likely make more changes to this package.