Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to the return value of Promise.allSettled #9

Merged
merged 8 commits into from
Jul 25, 2022
Merged

Adapt to the return value of Promise.allSettled #9

merged 8 commits into from
Jul 25, 2022

Conversation

ch-jobor
Copy link
Contributor

@ch-jobor ch-jobor commented Jul 23, 2022 •
edited by sindresorhus
Loading

When I use p-settle to replace Promise.allSettled in my project for throttling, I want its return value can be adapted to the return of Promise.allSettled

Fixes #8

@sindresorhus
Copy link
Owner

// @tychenjiajun

@tychenjiajun
Copy link

// @tychenjiajun

LGTM

sindresorhus
sindresorhus reviewed Jul 24, 2022
View reviewed changes
index.js Show resolved Hide resolved
@sindresorhus sindresorhus merged commit 7fa209f into sindresorhus:main Jul 25, 2022
@ch-jobor ch-jobor deleted the adapt-to-promise-allSettled branch July 26, 2022 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add type guards isRejected and isFulfilled
3 participants
@ch-jobor @sindresorhus @tychenjiajun