Skip to content

Doesn't work with Electron #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Rush opened this issue Oct 26, 2018 · 1 comment
Closed

Doesn't work with Electron #107

Rush opened this issue Oct 26, 2018 · 1 comment

Comments

@Rush
Copy link
Contributor

Rush commented Oct 26, 2018

Please add an option to use system-wide xdg-open instead of a bundled xdg-open.

node:7178) UnhandledPromiseRejectionWarning: Error: spawn /electron/build/path/out/xdg-open ENOENT
    at Process.ChildProcess._handle.onexit (internal/child_process.js:229:19)
    at onErrorNT (internal/child_process.js:406:16)
    at process._tickCallback (internal/process/next_tick.js:63:19)
@Rush Rush mentioned this issue Oct 27, 2018
Merged
@sindresorhus
Copy link
Owner

Why are you using this package with Electron? Electron already has a native method for opening a file: https://electronjs.org/docs/api/shell#shellopenitemfullpath

@sindresorhus sindresorhus changed the title Doesn't work with electron Doesn't work with Electron Oct 29, 2018
jkawamoto added a commit to GooBox/file-share-desktop that referenced this issue Mar 9, 2019
@jkawamoto
refactor: use shell API to open downloads folder
4e5572f 
Switch to shell API from opn package according to this comment
sindresorhus/open#107 (comment)
@jkawamoto jkawamoto mentioned this issue Mar 9, 2019
Merged
sindresorhus pushed a commit that referenced this issue Mar 16, 2019
@Rush @sindresorhus
Use system xdg-open in Electron apps on Linux (#108)
6d3f255 
Fixes #107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Rush @sindresorhus