Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

Match the specification #8

Merged
merged 7 commits into from
Feb 7, 2020
Merged

Match the specification #8

merged 7 commits into from
Feb 7, 2020

Conversation

acagastya
Copy link
Contributor

I have:

  1. Specified ava version in package.json's devDependency to avoid crashing of test.js.
  2. Updated test.js to work with [email protected].
  3. Updated isNaN implementation to match as specified by ECMA262 specification.

@sindresorhus
Copy link
Owner

Thanks, but don't change the code style.

@acagastya
Copy link
Contributor Author

@sindresorhus do you mean, one should skip checking the typeof the variable?

If that is so, I think it may not be a good idea. ECMA262 specifies the procedure, and it is possible, in future a new feature is added which requires the function to adhere to the procedure they mentioned. That would break the idea of ponyfill at the first place.

@sindresorhus
Copy link
Owner

No, I'm talking the quote and other style changes.

@acagastya
Copy link
Contributor Author

Ah, I should have disabled Prettier for this file.

@acagastya
Copy link
Contributor Author

Updated.

@sindresorhus sindresorhus changed the title Specify ava version to avoid crashing of test.js + update isNaN function to match with ECMA262 specification Match the specification Feb 7, 2020
@sindresorhus sindresorhus merged commit 04388ed into sindresorhus:master Feb 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants