Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stripTextFragment option #130

Merged
merged 3 commits into from
Apr 7, 2021
Merged

Add stripTextFragment option #130

merged 3 commits into from
Apr 7, 2021

Conversation

adam-lynch
Copy link
Contributor

Resolves #129

adam-lynch
adam-lynch commented Mar 31, 2021
View reviewed changes
test.js Show resolved Hide resolved
sindresorhus
sindresorhus reviewed Apr 3, 2021
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
sindresorhus
sindresorhus reviewed Apr 3, 2021
View reviewed changes
readme.md Outdated Show resolved Hide resolved
@sindresorhus sindresorhus changed the title Add stripTextFragment option Add stripTextFragment option Apr 3, 2021
@sindresorhus
Copy link
Owner

Sorry, I think we were talking past each other. It should indeed strip http://sindresorhus.com/about#:~:text=hello => http://sindresorhus.com/about. I thought you were talking about doing this http://sindresorhus.com/about#main:~:text=hello => http://sindresorhus.com/about, which it should not do.

@adam-lynch
Copy link
Contributor Author

OK I've reverted that bit. I hope it's OK now

@sindresorhus sindresorhus merged commit 01a4a91 into sindresorhus:main Apr 7, 2021
@sindresorhus
Copy link
Owner

Looks good. Thanks 👍

@adam-lynch adam-lynch deleted the strip_text_fragment branch April 7, 2021 09:53
@snyk-bot snyk-bot mentioned this pull request Oct 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Strip text fragment option
2 participants
@adam-lynch @sindresorhus