Fix removeSingleSlash option adding slashes
#122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out the option caused single slashes to be added to URLs that had none because the `URL` constructor defaults pathname to `/` both on parse and .toString(), so I had to prevent overwriting `urlString` to be able to check if the passed URL's pathname is `/`. Also added an entry for the option to `index.test-d.ts`.
Can you add a regression test for that? |
|
Two of the added test cases already cover this, they will fail on master: https://github.com/sindresorhus/normalize-url/pull/122/files#diff-1dd241c4cd3fd1dd89c570cee98b79ddR138 It's not strictly a regression, more like an improvement for when |
sindresorhus
changed the title
removeSingleSlash option adding slashes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out the option caused single slashes to be added to URLs that had none because the
URLconstructor defaults pathname to/both on parse and .toString(), so I had to prevent overwritingurlStringto be able to check if the passed URL's pathname is/.Also added an entry for the option to
index.test-d.ts.