Allow any protocol in the duplicate slashes normalization #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this, duplicate slashes would be removed unless preceeded by "http" or "https" protocols. This was too strict. The regex was updated to allow for any 2+ character alphanumeric protocol. Went with requiring at least 2 characters since every scheme listed here (https://en.wikipedia.org/wiki/List_of_URI_schemes) is at least 2 characters.
Removes unnecessary group
|
I think it should have a length limit too. |
|
@sindresorhus Length limit set to 30. The longest one I found on the above referenced Wiki was 27, so 30 seemed reasonable. However, given the completely arbitrary nature of such a limit, I'm thinking it should either be much larger or configurable. What do you think? |
* Adds two new options, for min/max length of what the dupe slash removal regex recognizes as a protocol. * Updates tests to exercise the new options * Updates readme to document the new options
|
@sindresorhus Arbitrary bounds felt wrong so I went ahead and made this configurable. |
|
I'm not interested in having this configurable. The point is to prevent possible abuse. We can make it 50. |
sindresorhus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #114
Prior to this, duplicate slashes would be removed unless preceded by "http" or "https" protocols. This was too strict.
The regex was updated to allow for any 2+ character alphanumeric protocol. Went with requiring at least 2 characters since every scheme listed here (https://en.wikipedia.org/wiki/List_of_URI_schemes) is at least 2 characters.