Skip to content

Commit

Permalink
Remove <hr> declarations (#75)
Browse files Browse the repository at this point in the history
  • Loading branch information
atjn authored Aug 9, 2024
1 parent b3b9630 commit 42c631d
Show file tree
Hide file tree
Showing 7 changed files with 6 additions and 21 deletions.
15 changes: 0 additions & 15 deletions modern-normalize.css
Original file line number Diff line number Diff line change
Expand Up @@ -40,21 +40,6 @@ body {
margin: 0; /* Remove the margin in all browsers. */
}

/*
Grouping content
================
*/

/**
1. Add the correct height in Firefox.
2. Correct the inheritance of border color in Firefox. (https://bugzilla.mozilla.org/show_bug.cgi?id=190655)
*/

hr {
height: 0; /* 1 */
color: inherit; /* 2 */
}

/*
Text-level semantics
====================
Expand Down
2 changes: 1 addition & 1 deletion test/acceptance/chrome/rules.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ test('Improve consistency of default fonts in all browsers.', async t => {
.expect(Selector('body').getStyleProperty('font-family')).eql(`system-ui, "Segoe UI", Roboto, Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji"`);
});

test('Add the correct height in Firefox.', async t => {
test('<hr> should be the correct height.', async t => {
await t
.expect(Selector('hr[data-test--hr]').getStyleProperty('height')).eql('2px');
});
Expand Down
2 changes: 1 addition & 1 deletion test/acceptance/chrome/validation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ test('Improve consistency of default fonts in all browsers.', async t => {
.expect(Selector('body').getStyleProperty('font-family')).notEql('system-ui, "Segoe UI", Roboto, Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji"');
});

test('Add the correct height in Firefox.', async t => {
test('<hr> should be the correct height.', async t => {
await t
.expect(Selector('hr[data-test--hr]').getStyleProperty('height')).notEql('2px');
});
Expand Down
2 changes: 1 addition & 1 deletion test/acceptance/firefox/rules.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ test('Improve consistency of default fonts in all browsers.', async t => {
.expect(Selector('body').getStyleProperty('font-family')).eql(`system-ui, "Segoe UI", Roboto, Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji"`);
});

test('Add the correct height in Firefox.', async t => {
test('<hr> should be the correct height.', async t => {
await t
.expect(Selector('hr[data-test--hr]').getStyleProperty('height')).eql('2px');
});
Expand Down
2 changes: 1 addition & 1 deletion test/acceptance/firefox/validation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ test('Improve consistency of default fonts in all browsers.', async t => {
.expect(Selector('body').getStyleProperty('font-family')).notEql('system-ui, "Segoe UI", Roboto, Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji"');
});

test('Add the correct height in Firefox.', async t => {
test('<hr> should be the correct height.', async t => {
await t
.expect(Selector('hr[data-test--hr]').getStyleProperty('height')).notEql('2px');
});
Expand Down
2 changes: 1 addition & 1 deletion test/acceptance/safari/rules.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ test('Improve consistency of default fonts in all browsers.', async t => {
.expect(Selector('body').getStyleProperty('font-family')).eql(`system-ui, "Segoe UI", Roboto, Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji"`);
});

test('Add the correct height in Firefox.', async t => {
test('<hr> should be the correct height.', async t => {
await t
.expect(Selector('hr[data-test--hr]').getStyleProperty('height')).eql('2px');
});
Expand Down
2 changes: 1 addition & 1 deletion test/acceptance/safari/validation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ test('Improve consistency of default fonts in all browsers.', async t => {
.expect(Selector('body').getStyleProperty('font-family')).notEql('system-ui, "Segoe UI", Roboto, Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji"');
});

test('Add the correct height in Firefox.', async t => {
test('<hr> should be the correct height.', async t => {
await t
.expect(Selector('hr[data-test--hr]').getStyleProperty('height')).notEql('2px');
});
Expand Down

0 comments on commit 42c631d

Please sign in to comment.