Improve robustness of request construction #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #507
This PR aims to reduce the likelihood that the user provided request options will be clobbered or ignored as a result of how we construct requests. Copying requests is necessary in some cases, but it's risky as the API is error-prone and so it is best avoided when possible.
Additionally, this PR fixes the root cause of flakiness in the retry tests and re-enables concurrent tests. The performance observers used previously were returning bogus data. Somehow they were caching measurements and returning identical measurement data between completely separate tests and observer instances. Really bizarre. Luckily, we can achieve exactly the same thing and more reliably with even simpler code by just comparing two calls to
performance.now()!